D26113: Places: For mounted volume display mount points instead of description

[Méven Car]

meven added a comment.


  In D26113#642018 <https://phabricator.kde.org/D26113#642018>, @bruns wrote:
  
  > In D26113#641998 <https://phabricator.kde.org/D26113#641998>, @meven wrote:
  >
  > > In D26113#641190 <https://phabricator.kde.org/D26113#641190>, @bruns wrote:
  > >
  > > > In D26113#581228 <https://phabricator.kde.org/D26113#581228>, @ngraham wrote:
  > > >
  > > > > > As Vaults are not backed by an fstab entry, it would be the responsibility of Vaults to set a useful name (via x-gvfs-name).
  > > > >
  > > > > What I'm saying is that I think it makes sense for Solid to provide a better default display string so each app doesn't have to do this.
  > > >
  > > >
  > > > What I'm saying is that Vaults should set a meaningful value via x-gvfs-name so Solid has not to invent something. Then Solid can use that, and it would be consistent everywhere.
  > >
  > >
  > > I see, so I think we should add a "displayName" (or label() similarly to StorageVolume) function to Solid::Device, so that x-gvfs-name is used for this or the mount point when not defined and keeping description as is : a verbose description of the Device that could be used in tooltips for instance.
  > >  This displayName would default on description() so that it would be an opt-in change by Device implementation and then users can choose between description() and displayName() depending on the context and role they need. So here in kfileplacesitem we would replace description() by displayName().
  > >  Does this idea make sense to you @bruns ?
  >
  >
  > Its already there:
  >
  >   grep x-gvfs-name  /etc/fstab 
  >   //pebbles/share /mnt cifs defaults,x-gvfs-show,x-gvfs-icon=yast-samba-server,x-gvfs-name=SambaShare
  >
  >
  >   solid-hardware5  details /org/kde/fstab///pebbles/share
  >   udi = '/org/kde/fstab///pebbles/share'
  >     parent = '/org/kde/fstab'  (string)
  >     vendor = 'pebbles'  (string)
  >     product = 'share'  (string)
  >     description = 'SambaShare'  (string)
  >     icon = 'yast-samba-server'  (string)
  >     StorageAccess.accessible = false  (bool)
  >     StorageAccess.filePath = '/mnt'  (string)
  >     StorageAccess.ignored = false  (bool)
  >     NetworkShare.type = 'Cifs'  (0x2)  (enum)
  >     NetworkShare.url = 'smb://pebbles/share'  (string)
  >
  >
  > F8216997: Screenshot_20200405_124325.png <https://phabricator.kde.org/F8216997>
  
  
  A lot of users won't have a x-gvfs-name for whatever reason and we can't expect them to be take savy with root access to set up a x-gvfs-name mount option.
  I see your point but my last one was how to make the display by default better (not using description()), but keeping displaying x-gvfs-name value when defined by the user.
  
  So we need a more general solution, which is what I suggest.
  
  Moreover setting description to x-gvfs-name makes the original description content inaccessible to application despite it could be valuable, for instance for tooltip.
  So I think putting x-gvfs-name in description was abusing the API for it was lacking a proper displayName/label field to begin with.
  I hope this clarifies my suggestion in https://phabricator.kde.org/D26113#641998

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200405/c0482371/attachment-0001.html>