D28582: KRunner: Show error message for Actions in dbus runner
Alexander Lohnau
noreply at phabricator.kde.org
Sun Apr 5 09:28:19 BST 2020
alex created this revision.
alex added reviewers: Plasma, davidedmundson, broulik, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alex requested review of this revision.
REVISION SUMMARY
KRunner now shows error messages for the Actions dbus request.
But they get only shown if the service is not unknown, because the same error message will be shown in the match method.
TEST PLAN
Make sure that the logging category is enabled and verify that you get debug output when starting KRunner.
Create a runner for example https://cgit.kde.org/scratch/davidedmundson/pythonrunner.git/tree/runner.py and install it.
Make sure that the Actions method is valid and returns actions, they should be displayed without warnings.
Change the return value from a list to 123, a TypeError message should be displayed.
Kill the runner, and type one letter in KRunner. The ServiceUnknown error message gets shown only once (from the match method).
REPOSITORY
R308 KRunner
BRANCH
dbusrunner_cleanup (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28582
AFFECTED FILES
src/dbusrunner.cpp
To: alex, #plasma, davidedmundson, broulik, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200405/5c4dd618/attachment.html>
More information about the Kde-frameworks-devel
mailing list