D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Sun Apr 5 08:41:59 BST 2020
bruns added a comment.
looks good to me otherwise
INLINE COMMENTS
> jobtest.cpp:1537
> +
> + // this test doesn't make sense on the CI as it's an LXC container with one partition
> + if (otherTmpDirIsOnSamePartition()) {
slight rewording
// In case the two tmp dirs are on the same partition (e.g. on the CI), the
// device IDs should match, otherwise they should be different
and then
} else {
QCOMPARE(device, otherDevice);
}
> ahmadsamir wrote in jobtest.cpp:1510
> OK, that makes sense. Done.
nitpick - the test name now again is wrong ;-)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28478
To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200405/318d21bd/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list