D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sat Apr 4 12:22:46 BST 2020


bruns added inline comments.

INLINE COMMENTS

> jobtest.cpp:1510
> +{
> +    // this test doesn't make sense on the CI as it's an LXC container with one partition
> +    if (!otherTmpDirIsOnSamePartition()) {

This should only apply to the `QVERIFY(device != otherDevice);`

> bruns wrote in jobtest.cpp:1524
> Its 'statDetails**With**Inode' not 'statDetailsInode**Only**'

i.e. the test should be renamed now.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200404/48171bbe/attachment.html>


More information about the Kde-frameworks-devel mailing list