D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

Harald Sitter noreply at phabricator.kde.org
Fri Apr 3 17:10:47 BST 2020


sitter added inline comments.

INLINE COMMENTS

> kossebau wrote in kio_smb_browse.cpp:239
> `QString::remove()` operates on the object itself, no need to assign back to host.
> 
> Besides, why not use `QString::chop(wsdSuffix.size())` ?

Mh. Good point indeed, I'll move to chop. Thanks!

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-lazy-resolve

REVISION DETAIL
  https://phabricator.kde.org/D28513

To: sitter, ngraham, meven
Cc: kossebau, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200403/624c74fd/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list