D28538: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

Méven Car noreply at phabricator.kde.org
Fri Apr 3 15:28:29 BST 2020


meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Seems hard to miss cases like for `// +1 for UDS_DISPLAY_NAME` but I will trust you did enough review to be confident for all those cases.
  A missing one will just cause an allocation anyway which is what this is fixing in the first place, so no arm done basically.

REPOSITORY
  R320 KIO Extras

BRANCH
  usemoreudsentryreserve

REVISION DETAIL
  https://phabricator.kde.org/D28538

To: kossebau, #frameworks, sitter, meven
Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200403/e18cd901/attachment.html>


More information about the Kde-frameworks-devel mailing list