D28535: [KIO-MTP] Fix null pointer dereference

Anthony Fieroni noreply at phabricator.kde.org
Fri Apr 3 14:20:03 BST 2020


anthonyfieroni added a comment.


  In D28535#640699 <https://phabricator.kde.org/D28535#640699>, @feverfew wrote:
  
  > So to be succinct, the only correct fix here is to change `getDevice()` to `return m_mtpdevice`?
  
  
  Yes, then check if it's crash, in all other place `LIBMTP_xxx` should take care of and return false or nullptr depend of function returning value.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28535

To: feverfew, akrutzler, dfaure, elvisangelaccio
Cc: anthonyfieroni, kde-frameworks-devel, fvogt, kfm-devel, ngraham, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200403/6ac13922/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list