D28498: [xdgoutput] Explicitly set version of server interface
Vlad Zahorodnii
noreply at phabricator.kde.org
Fri Apr 3 09:18:01 BST 2020
zzag added inline comments.
INLINE COMMENTS
> apol wrote in display.h:296
> Passing an enum as const& is wrong although it doesn't make much of a difference in practice.
>
> `You can't introduce another createXdgOutputManager() because it's not overloaded`. He's adding an overload, I don't understand.
> He's adding an overload, I don't understand.
Bad wording, my bad. We are allowed to overload only methods that are already overloaded.
From https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B
> You cannot...
>
> For existing functions of any type:
>
> add an overload (BC, but not SC: makes &func ambiguous), adding overloads to already overloaded functions is ok (any use of &func already needed a cast).
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D28498
To: davidedmundson, #kwin
Cc: zzag, anthonyfieroni, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200403/0f1047eb/attachment.html>
More information about the Kde-frameworks-devel
mailing list