D28522: [QtQuick dialog] Port to UrlBUtton and hide when there's no URL

Nathaniel Graham noreply at phabricator.kde.org
Thu Apr 2 18:18:42 BST 2020


ngraham created this revision.
ngraham added reviewers: leinir, KNewStuff, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Port from `linkButton` to `UrlButton` for links that open webpages, as this is what
  `UrlButton` was specifically designed for. Also hide any link that doesn't actually go
  anywhere because the URL isn't defined by the data source.

TEST PLAN
  F8211891: Screenshot_20200402_111651.png <https://phabricator.kde.org/F8211891>
  
  There's no longer a donation button that doesn't do anything when clicked, and the
  homepage link shows a tooltip when hovered.

REPOSITORY
  R304 KNewStuff

BRANCH
  port-to-urlbutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28522

AFFECTED FILES
  src/qtquick/qml/EntryDetails.qml

To: ngraham, leinir, #knewstuff, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200402/0bc61844/attachment.html>


More information about the Kde-frameworks-devel mailing list