D28488: [Fstab] Ensure uniqueness for all filesystem types

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added a comment.


  In D28488#639942 <https://phabricator.kde.org/D28488#639942>, @broulik wrote:
  
  > Wat. So maybe we need to add a hash of mount options to it? (Though I personally would call that pebkac)
  
  
  +1

INLINE COMMENTS

> sitter wrote in fstabhandling.cpp:131
> 
> 
>   λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o user=me              
>   λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o user=me
>   λ ajax ~ → sudo mount --bind /tmp /mnt             
>   λ ajax ~ → sudo mount --bind /tmp /mnt
>   λ ajax ~ → mount|grep /mnt                                    
>   //bear.local/foo on /mnt type cifs (rw,relatime,vers=3.1.1,cache=strict,username=me,uid=0,noforceuid,gid=0,noforcegid,addr=fd00:0000:0000:0000:8c8d:02ff:fec7:d6a4,file_mode=0755,dir_mode=0755,soft,nounix,serverino,mapposix,rsize=4194304,wsize=4194304,bsize=1048576,echo_interval=60,actimeo=1)
>   //bear.local/foo on /mnt type cifs (rw,relatime,vers=3.1.1,cache=strict,username=me,uid=0,noforceuid,gid=0,noforcegid,addr=2a03:c100:f100:4f00:8c8d:02ff:fec7:d6a4,file_mode=0755,dir_mode=0755,soft,nounix,serverino,mapposix,rsize=4194304,wsize=4194304,bsize=1048576,echo_interval=60,actimeo=1,user=me)
>   /dev/nvme1n1p1 on /mnt type btrfs (rw,relatime,ssd,space_cache,subvolid=1082,subvol=/@/tmp)
>   /dev/nvme1n1p1 on /mnt type btrfs (rw,relatime,ssd,space_cache,subvolid=1082,subvol=/@/tmp)

The first mount is no longer visible, it is shadowed by the first one. You can not read any files from it or write to it. You can not  unmount it.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200402/53b4762e/attachment.html>