D28504: [EngineQuery] Remove unused position member, extend tests

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Apr 2 10:01:50 BST 2020


bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The "pos" member is unused, remove it from the EngineQuery class.

TEST PLAN
  ctest
  $> baloosearch foo png -> finds foo.png and foo_bar.png
  $> baloosearch foo.png -> still finds foo.png, but not foo_bar.png

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28504

AFFECTED FILES
  autotests/unit/engine/queryparsertest.cpp
  src/engine/enginequery.cpp
  src/engine/enginequery.h
  src/engine/queryparser.cpp
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200402/0245a514/attachment.html>


More information about the Kde-frameworks-devel mailing list