D28472: [DirectorySizeJob] Fix sub-dirs count when resolving symlinks to dirs

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, meven.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  After 730a6ddd828fb1fbdf0f3 <https://phabricator.kde.org/R241:730a6ddd828fb1fbdf0f3d70412f6da4eeb1b912>, the behaviour changed and the code sets
  KIO::UDSEntry::UDS_DEVICE_ID after symlinks are resovled (if
  KIO::StatResolveSymlink is set); this meant that if we have dir A and
  a symlink to it B, the loop that detects hard-links will skip A if B
  was processed before, as both will have the same inode.
  
  This fixes the directorySize() unit test from kiocore-jobtest; the
  totalSubdirs() count didn't match the expected value.

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  l-dirsizejob (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28472

AFFECTED FILES
  src/core/directorysizejob.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200401/90e5a634/attachment.html>