D24171: [src/filewidgets/*] replace deprecated foreach with range for

David Faure noreply at phabricator.kde.org
Sat Sep 28 19:58:34 BST 2019


dfaure added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in kurlnavigator.cpp:803
> I thought button->deleteLater() may change m_navButtons, doesn't it?

How would it? It doesn't know that container. All it does is posting an event to that object. The container isn't modified.

[and even a real C++ `delete` wouldn't modify the container itself, only the objects it points to]

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24171

To: ahmadsamir, kde-frameworks-devel, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190928/c903cad7/attachment.html>


More information about the Kde-frameworks-devel mailing list