D24262: Modernize code: use range-based loops & algorithms in more places

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> dhaumann wrote in plugin.cpp:196
> cbegin() + cend()
> Catch library by reference? [& library]

Do we have rules in KF whether stl-like names liks cbegin() & cend() are fine?
Then plugins is const, so begin()/end() are giving use the const iterators already.

Does it make sense to catch the reference `library` by reference? Myself do not have a stable best-practice rules here, so happy to learn more.

> dhaumann wrote in statusbarextension.cpp:139
> qAsConst?

container elements are modified.

> dhaumann wrote in statusbarextension.cpp:143
> Same here?

Same here :)

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D24262

To: kossebau, dfaure
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190928/27a5a353/attachment.html>