D23926: Move "Details" tab to second place in Properties dialog

Matej Mrenica noreply at phabricator.kde.org
Fri Sep 27 16:06:40 BST 2019


mthw added a comment.


  > 3. Instead of unconditionally doing `q->insertPluginAt(plugin, 1);`, you'd want to do something more like this:
  > 
  > 
  > 
  >   if (plugin == "details"  /* this is pseudocode */) {
  >       q->insertPluginAt(plugin, 1);
  >   } else {
  >       q->insertPlugin(plugin);
  >   }
  > 
  > 
  > I'm actually not sure how to check for what the plugin is though. Maybe someone from #frameworks <https://phabricator.kde.org/tag/frameworks/> can help.
  
  This is mostly done but we still need to do this the check, but neither me nor @ngraham know how to do it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190927/e6940cb5/attachment.html>


More information about the Kde-frameworks-devel mailing list