D24166: Status bar mode menu: Reuse empty QIcon that is implicitly shared

Dominik Haumann noreply at phabricator.kde.org
Mon Sep 23 18:22:41 BST 2019


dhaumann created this revision.
dhaumann added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  Instead of creating N empty QIcons, use just one QIcon
  that internally is implicitly shared, see:
  https://doc.qt.io/qt-5/implicit-sharing.html

TEST PLAN
  make

REPOSITORY
  R39 KTextEditor

BRANCH
  use-qicon-implicitly-shared

REVISION DETAIL
  https://phabricator.kde.org/D24166

AFFECTED FILES
  src/mode/katemodemenulist.cpp

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190923/b280c695/attachment.html>


More information about the Kde-frameworks-devel mailing list