D23902: [KCoreDirLister] replace deprecated foreach with range-for

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kcoredirlister.cpp:1044
> Actually, I was wrong.
> I talked to the head of the LLVM/clang development team at Apple and he told me that returning a const value has zero effect whatsoever. I.e. in the version of your patch where you were returning a const value, the range for would *still* call the non-const begin() and end(). Good thing I made you change that :-)
> 
> His plan is to make a future version of the C++ standard deprecate const arguments and const return values in function declarations. (toplevel const only, const-ref is fine of course).

Noted. :)
(Thanks for sharing).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23902

To: ahmadsamir, kde-frameworks-devel, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190922/8f6dca7b/attachment-0001.html>