D21897: Address some issues reported by Krazy analysis

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> pajamapants3000 wrote in ktextedit.cpp:373
> Thank you broulik! Could we use a `QScopedPointer` here? I see them throughout the KDE source, but not often for dialogs. The krazy analysis looked for `QPointer`, referencing blog https://blogs.kde.org/node/3919, which appears to have predated the existence of `QScopedPointer`.

While we are at it, the best way to fix this would be to not use `exec()` at all, but use `open()` instead: https://wiki.qt.io/New_Signal_Slot_Syntax#Asynchronous_made_easier

REPOSITORY
  R310 KTextWidgets

BRANCH
  krazy-50b2564 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21897

To: pajamapants3000, elvisangelaccio
Cc: broulik, vkrause, elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190921/3153f56c/attachment.html>