D23579: WIP: port ftp slave to new error reporting system

Anthony Fieroni noreply at phabricator.kde.org
Sat Sep 21 06:42:36 BST 2019


anthonyfieroni added inline comments.

INLINE COMMENTS

> ftp.h:49
>  //===============================================================================
> -class Ftp : public QObject, public KIO::SlaveBase
>  {

That's BIC we cannot remove, reorder nor insert parent(s)

> ftp.h:167
> +
> +class FtpInternal : public QObject
> +{

Should be hidden?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23579

To: sitter, dfaure
Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190921/38922169/attachment.html>


More information about the Kde-frameworks-devel mailing list