D24050: Deploy default avatar via qrc

Volker Krause noreply at phabricator.kde.org
Wed Sep 18 14:07:19 BST 2019


vkrause added a comment.


  Approch makes sense in genereal, just minor nitpicks.

INLINE COMMENTS

> CMakeLists.txt:15
>  set(REQUIRED_QT_VERSION 5.11.0)
> +set(CMAKE_AUTORCC ON)
>  

This is the default starting at ECM 5.62.

> resources.qrc:2
> +<RCC>
> +    <qresource prefix="/">
> +        <file>pixmaps/dummy_avatar.png</file>

I'd namespace the prefix by framework, e.g. org.kde.kpeople.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D24050

To: nicolasfella, apol
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190918/d68ce8dd/attachment.html>


More information about the Kde-frameworks-devel mailing list