D24023: Delete QQmlObjectSharedEngine context in sync with QQmlObject

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Otherwise we leave a context dangling with no engine, which is weird.
  
  I suspect it was done like this as we need the context to outlive the
  lifespan of the superclass QQmlObject, but we can use the QObject
  child-parent for that.
  
  It shouldn't have any negative behavioural changes as this matches the
  behaviour of QmlObject which all original code was once ported from.
  
  See also https://bugreports.qt.io/browse/QTBUG-78326

TEST PLAN
  Ran Qt5.14
  Locked the screen
  Unlocked the screen, successfully

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24023

AFFECTED FILES
  src/kdeclarative/qmlobjectsharedengine.cpp

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190917/33b6fa48/attachment.html>