D24014: [KWayland] Port away from deprecated API in Qt 5.14

Vlad Zahorodnii noreply at phabricator.kde.org
Tue Sep 17 13:12:10 BST 2019


zzag accepted this revision.
zzag added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> dfaure wrote in test_wayland_surface.cpp:396
> The "Almost Always Auto" crowd would disagree with you, but sure, your choice. Done.

Putting auto everywhere is a terrible thing! Surely it makes refactoring a bit easier, however you kill readability by erasing types.

Qt has a really good auto keyword usage guideline. https://wiki.qt.io/Coding_Conventions#auto_Keyword

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24014

To: dfaure, davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190917/e237e1d1/attachment.html>


More information about the Kde-frameworks-devel mailing list