D24012: Supress mouse events in KCMs causing window moves

Anthony Fieroni noreply at phabricator.kde.org
Tue Sep 17 07:24:12 BST 2019


anthonyfieroni added inline comments.

INLINE COMMENTS

> kcmoduleqml.cpp:265-268
> +    bool rc = KCModule::event(event);
> +    if (event->type () == QEvent::MouseButtonPress || event->type() == QEvent::MouseButtonRelease) {
> +        event->accept();
> +    }

Should we check `if (rc && ...)` if rc is false event is not handled no?

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D24012

To: davidedmundson, #plasma
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190917/37166c7c/attachment.html>


More information about the Kde-frameworks-devel mailing list