D23815: [KConfig] port away from deprecated methods in Qt 5.14
Pino Toscano
noreply at phabricator.kde.org
Tue Sep 17 05:38:51 BST 2019
pino added a comment.
In D23815#528543 <https://phabricator.kde.org/D23815#528543>, @dfaure wrote:
> If we want to enable this flag (to "punish" the first KDE developer who upgrades Qt, like me currently), then at least we should only do so in git checkouts, not in release tarballs.
> This is easy to do: `if (EXISTS "${CMAKE_SOURCE_DIR}/.git")`.
Note that "being in git" does not imply "this is the development repository": there are distributions that maintain the sources expanded in git repositories [1], so the check would be mistakenly triggered in those cases.
[1] https://wiki.debian.org/PackagingWithGit
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D23815
To: dfaure, mdawson, arichardson, vkrause
Cc: pino, arojas, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190917/a4472400/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list