D22365: KNotification macOS native support by NSNotificationCenter

[René J.V. Bertin]

rjvbb added a comment.


  >   Yeah, you're right that we should check system version for back-compatibility.
  
  Actually, I didn't want to suggest that. I haven't checked, but I think that the Qt requirement already ensures that the Cocoa APIs that you are using are present.
  
  >   AFAIU, we can check it before the creation of notification backend instance, if not compatible, use the old implementation, right?
  
  Yes - but if the backend compiles (without or with #ifdefs).
  
  >   I don't know XCB QPA stuff. Investigating then...
  
  Don't take my XCB QPA remarks as a blocker, but do have a look if there's some kind of mechanism in place to check whether an application is running in a full GUI environment. Not necessarily as part of this change request - I'm thinking out loud here, in fact.

REVISION DETAIL
  https://phabricator.kde.org/D22365

To: Inoki, rjvbb, nicolasfella
Cc: nicolasfella, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190916/8d23c5d2/attachment-0001.html>