D24003: kwaylandScanner produce version enum per class

Vlad Zahorodnii noreply at phabricator.kde.org
Mon Sep 16 20:44:24 BST 2019


zzag added a comment.


  FYI, https://phabricator.kde.org/D22362#493722

INLINE COMMENTS

> generator.cpp:431
>              auto it = std::find_if(m_interfaces.constBegin(), m_interfaces.constEnd(), [] (const Interface &i) { return i.isGlobal(); });
> -            if (it != m_interfaces.constEnd()) {
> +            while (it != m_interfaces.constEnd()) {
>                  const QString templateString = QStringLiteral(

Is it correct thogugh? Can you provide some test input so it's easier to see the problem?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24003

To: gladhorn, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190916/55b404ad/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list