D23586: Improve code that detects useful elements in an Svg file

Frederik Gladhorn noreply at phabricator.kde.org
Sat Sep 14 21:59:45 BST 2019


gladhorn added inline comments.

INLINE COMMENTS

> svg.cpp:103
>          while (!reader.atEnd()) {
> -            if (reader.readNext() == QXmlStreamReader::StartElement &&
> +            const auto t = reader.readNext();
> +            if (t == QXmlStreamReader::StartElement) {

Maybe use "element" instead of "t" as variable name?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23586

To: apol, #plasma, #frameworks
Cc: gladhorn, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190914/562a9d02/attachment.html>


More information about the Kde-frameworks-devel mailing list