D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1
  
  In D23851#529463 <https://phabricator.kde.org/D23851#529463>, @ngraham wrote:
  
  > If the on;y thing that `EmptyTrashJob::slotFinished()` does now is call `SimpleJob::slotFinished()`, do we even still need to override the base class's implementation of `slotFinished()`?
  
  
  Yeah we don't, but we can't remove it because it would be a BIC.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23851

To: meven, broulik, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190913/c0fe5509/attachment.html>