D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Meanwhile lsof was installed on the Linux CI nodes, but this fix is still good to have of course, just in case.

INLINE COMMENTS

> klistopenfilesjobtest_unix.cpp:34
> +
> +bool HasLsofInstalled()
> +{

Method names start with a lowercase letter in Qt/KDE code.

> klistopenfilesjobtest_unix.cpp:67
> +    if (!HasLsofInstalled()) {
> +        qDebug() << "lsof is not installed - skipping test";
> +        return;

Please use QSKIP instead, otherwise the test output looks like the test passed, rather than was skipped.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23884

To: hallas, dfaure
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190912/596754eb/attachment.html>