D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  When creating multiple nested new folders, one at a time, in the "save as"
  dialog, where folders are created and entered, a dirlister would hit an
  assert (in DirItem::reinsert()), because one of the created folders would
  eventually get inserted in pendingUpdates.
  
  Add a unit test in kfilewidgettest.
  
  BUG: 408801
  FIXED-IN: 5.62.0

TEST PLAN
  - Open a file in e.g. okular, then "save as"
  - Create a new folder from the dialog, then another ... etc, usually 2-3 new folders would hit the assert (keep going, the number varies apparently) and the app would crash
  - Apply the patch then try again, it shouldn't crash any more

REPOSITORY
  R241 KIO

BRANCH
  ahmad/kcoredirlister (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23875

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/core/kcoredirlister_p.h

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190911/0b2ddd5c/attachment.html>