D23832: Backup on save: Support time and date string replacements

Dominik Haumann noreply at phabricator.kde.org
Wed Sep 11 07:09:08 BST 2019


dhaumann added inline comments.

INLINE COMMENTS

> katedocument.cpp:2594
> +    const auto backupSuffix = KTextEditor::EditorPrivate::self()->variableExpansionManager()->expandText(config()->backupSuffix(), nullptr);
> +    if (backupPrefix.contains(QDir::separator())) {
>          /**

Shall we wrap all this with

  if (!(backupSuffix.isEmpty() && backupPrefix.isEmpty())) {...}

REPOSITORY
  R39 KTextEditor

BRANCH
  bug

REVISION DETAIL
  https://phabricator.kde.org/D23832

To: dhaumann, cullmann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190911/c606cde1/attachment.html>


More information about the Kde-frameworks-devel mailing list