D23861: Port away from Qt's foreach: loop directly over pimpl member

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Wed Sep 11 01:09:38 BST 2019


kossebau created this revision.
kossebau added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The old implementation of all the KActionCollection methods was a bit
  inconsistent: some places loop directly over d->actions, while others do
  it over the container copy created via call to the public getter method.
  Without obvious reason for the different approach.
  
  This patch ports the remaining foreach (and one ported before) to
  a range-based for loop directly over the pimpl container object.

REPOSITORY
  R263 KXmlGui

BRANCH
  portloopdirectlyoverdmembers

REVISION DETAIL
  https://phabricator.kde.org/D23861

AFFECTED FILES
  src/kactioncollection.cpp

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190911/fcf676a9/attachment.html>


More information about the Kde-frameworks-devel mailing list