D23813: Port away from foreach loops over arguments without calls to owner class

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Thanks for review :)

INLINE COMMENTS

> dfaure wrote in kkeysequencewidget.cpp:127
> This could even be `const QString seq = it.key().toString();` so that toString() is only called once.

I try (hard, there are many temptations when looking at all exisiting loop code) to usually do not too much other improvements but stay on-topic of commit message change, but will do an exception given you asked for it, and the change will not confuse commit history reader too much :)

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23813

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190910/00455d17/attachment.html>