D23839: Port away from Qt's foreach

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Sep 10 16:38:39 BST 2019


kossebau added a comment.


  In D23839#528788 <https://phabricator.kde.org/D23839#528788>, @zzag wrote:
  
  > Did you use a script to create this patch?
  
  
  Nope, manually done.

INLINE COMMENTS

> zzag wrote in kwindowsystem_threadtest.cpp:61
> Capture the value by const ref please.

Would a const ref make sense here, given the type nature of WId which boils down to a integer matching the byte size of a pointer?

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D23839

To: kossebau, #kwin, zzag
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190910/fd58e53a/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list