D23815: [KConfig] port away from deprecated methods in Qt 5.14
David Faure
noreply at phabricator.kde.org
Tue Sep 10 08:47:05 BST 2019
dfaure created this revision.
dfaure added reviewers: mdawson, arichardson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
REVISION SUMMARY
In kconf_update, the ctime usage used to be about metadata change time
(buff.st_ctime, before it got ported to the misnamed created()).
I ported it to birthTime, because I think
date of birth is a more useful way to identify a file than
date of permission change which doesn't really matter to us.
But in practice, I can't help but wonder if mtime alone wouldn't be
enough.
For the QStringLiteral("%%1").arg(i) bit, I tested it in tst_qstring,
the first % is left untouched.
TEST PLAN
make && ctest
REPOSITORY
R237 KConfig
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23815
AFFECTED FILES
autotests/kconfigloadertest.cpp
autotests/kconfigtest.cpp
src/core/kcoreconfigskeleton.cpp
src/kconf_update/kconf_update.cpp
src/kconfig_compiler/kconfig_compiler.cpp
To: dfaure, mdawson, arichardson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190910/67cf43c0/attachment.html>
More information about the Kde-frameworks-devel
mailing list