D23813: Port away from foreach loops over arguments without calls to owner class

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  There is some small risk here:
  
  - overseen call chains which still call the owner and modify the container
  - other threads might access the same containers, even if class is not designed to be thread-safe, but wrong usages are currently caught mostly by the container copy
  
  GIT_SILENT

REPOSITORY
  R263 KXmlGui

BRANCH
  portmoreforeachmethodargswithotrecursivecalls

REVISION DETAIL
  https://phabricator.kde.org/D23813

AFFECTED FILES
  autotests/kxmlgui_unittest.cpp
  autotests/testguiclient.h
  autotests/testxmlguiwindow.h
  src/kkeysequencewidget.cpp
  src/kshortcutschemeshelper.cpp
  src/kxmlguiclient.cpp
  src/kxmlguifactory.cpp
  src/kxmlguiversionhandler.cpp

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190910/fdcfc8bf/attachment.html>