D23812: Port away from foreach loops over members without calls to owner class

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Sep 10 01:52:22 BST 2019


kossebau created this revision.
kossebau added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  There is some small risk here:
  
  - overseen call chains which still call the owner and modify the container
  - other threads might access the same containers, even if class is not designed to be thread-safe, but wrong usages are currently caught mostly by the container copy
  
  GIT_SILENT

REPOSITORY
  R263 KXmlGui

BRANCH
  portmoreforeachwithoutrecursivecalls

REVISION DETAIL
  https://phabricator.kde.org/D23812

AFFECTED FILES
  src/kactioncollection.cpp
  src/kgesture.cpp
  src/kkeysequencewidget.cpp
  src/kshortcutsdialog.cpp
  src/kshortcutseditor.cpp
  src/ktoolbar.cpp
  src/ktoolbarhandler.cpp
  src/kxmlguiclient.cpp
  src/kxmlguifactory.cpp
  src/kxmlguifactory_p.cpp

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190910/834595dd/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list