D23787: [baloo_file_extractor] Improve handling of large plain-text files

Kai Uwe Broulik noreply at phabricator.kde.org
Sun Sep 8 13:07:51 BST 2019


broulik added inline comments.

INLINE COMMENTS

> app.cpp:183
> +        // have trouble processing them
> +        if ((ex->extractorProperties()["Name"].toString() == QLatin1String("PlaintextExtractor")) && (QFileInfo(url).size() >= 10 * 1024 * 1024)) {
> +            qCWarning(BALOO) << "Skipping" << url << ": large plain text file";

Store the size in a variable outside the loop, otherwise you end up querying it on each iteration.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23787

To: poboiko, #baloo, bruns, ngraham
Cc: broulik, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190908/32ab837b/attachment.html>


More information about the Kde-frameworks-devel mailing list