D23411: Fix crash in writer collection and cleanup

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> writer.h:63
>  
> +    WriterPrivate *d;
>      friend class WriterCollection;

Why's this change?

> writercollection.cpp:133
> +        Writer writer;
> +        writer.d->m_plugin = plugin;
> +        writer.setAutoDeletePlugin(Writer::AutoDeletePlugin);

maybe it would make sense to use shared pointers there?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D23411

To: astippich, bruns, mgallien, ngraham
Cc: apol, kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190907/1fa711e2/attachment-0001.html>