D23708: [CopyJob] Fix crash when copying an already existing dir and pressing "Skip"

[Ahmad Samir]

ahmadsamir marked an inline comment as done.
ahmadsamir added a comment.


  In D23708#525848 <https://phabricator.kde.org/D23708#525848>, @dfaure wrote:
  
  > Thanks for the fix!
  >
  > Do you feel like writing a unittest for it?
  >  JobTest::chmodFileError shows how to use PredefinedAnswerJobUiDelegate to simulate the user pressing "Skip" in the dialog.
  >  Write the test without your fix applied, so that you are sure it triggers the crash, before re-applying the fix.
  
  
  That's exactly what I did.
  
  Thanks.

INLINE COMMENTS

> dfaure wrote in copyjob.cpp:1640
> This comment only needs to be in the unittest, not in the code.
> 
> If every bugfix leads to two lines of comments, the code becomes unreadable.

OK.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23708

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190905/a8bed4d8/attachment.html>