D23576: Add property lastScanTime and lastRequestTime to WirelessDevice
Méven Car
noreply at phabricator.kde.org
Wed Sep 4 12:15:41 BST 2019
meven added inline comments.
INLINE COMMENTS
> jgrulich wrote in wirelessdevice.h:143
> Thinking about it now, wouldn't be this wording better?
>
> QDateTime lastScanRequestTime() const;
>
> Maybe even without the "Time" at the end so it's consistent with "lastScan".
I chose lastRequestScanTime to have RequestScan in the name, that is the function, it keeps the last time called from.
The Time suffix does not feel great indeed.
I can make an adjustment to `lastRequestScan`, I will adjust D23578 <https://phabricator.kde.org/D23578> then
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D23576
To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190904/80a04d8c/attachment.html>
More information about the Kde-frameworks-devel
mailing list