D23707: Fix crash on teardown with Applet's ConfigLoader

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Deleting AppletPrivate will delete the ConfigLoader which will cause a
  save, which can trigger a configSaved signal.
  
  I think it is correct that the config might emit a signal just before
  closing, and not at fault.
  
  AppletPrivate is deleted by this point, but Applet is not so the
  connection is still alive.
  
  When we handle the signal, it goes into a Q_PRIVATE_SLOT that crashes.
  
  This disconnect pattern is already used for guarding self config
  changes.
  
  BUG: 411221

TEST PLAN
  kquitapp5 plasmashell, no longer crashes

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23707

AFFECTED FILES
  src/plasma/applet.cpp

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190903/d3e3b662/attachment.html>