D23667: Add == and != operators to KIO::UDSEntry

[Nathaniel Graham]

ngraham added a comment.


  I know it seems silly for such tiny functions, but can you follow the pattern and keep only the function definitions in the header file and move the actual logic into the .cpp file?

INLINE COMMENTS

> udsentry.h:118
> +    /**
> +     * Returns true if the entry contains the same data as other
> +     * @since 5.62.0

as other -> as the other

> udsentry.h:119
> +     * Returns true if the entry contains the same data as other
> +     * @since 5.62.0
> +     */

Just `5.62` (Frameworks don't have minor versions)

> udsentry.h:127
> +    /**
> +     * Returns true if the entry does not contain the same data as other
> +     * @since 5.62.0

ditto

> udsentry.h:128
> +     * Returns true if the entry does not contain the same data as other
> +     * @since 5.62.0
> +     */

ditto

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23667

To: meven, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190903/7d66233f/attachment-0001.html>