D23682: Make use of KPluginMetaData where we can

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> containmentactions.h:70
>       *         including name, pluginName and icon
> -     * @since 5.0
> +     * @since 5.0 use metadata
>       */

@deprecated since 5.62 use metadata

> dataengine.cpp:70
>      : QObject(parent),
> -      d(new DataEnginePrivate(this, KPluginInfo(args), args))
> +      d(new DataEnginePrivate(this, KPluginInfo(args).toMetaData(), args))
>  {

Where is this constructor used?

> dataengine.h:80
> +
> +    explicit DataEngine(const KPluginMetaData &plugin, QObject *parent = nullptr);
>  

Docs, with `@since`

> dataengine.h:112
> +     *
> +     * @since 4.62
>       */

5

> dataenginescript.cpp:91
>  
>  KPluginInfo DataEngineScript::description() const
>  {

Does this need a `KPluginMetadata` getter?

> theme.cpp:444
>  
>  KPluginInfo Theme::pluginInfo() const
>  {

Does this need a separate `metadata()` getter?

> theme.h:321
>       * name, description, author, website etc
> -     * @since 5.0
> +     * @since 5.0 use KPluginMetaData
> +     */

Separate `@deprecated since` line

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23682

To: apol, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190902/a7f4072d/attachment-0001.html>