D22510: Added dialog to set execute permission for executable file when trying to run it.

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> krun.cpp:164
>  
> +bool KRun::hasExecuteBit(const QString &fileName)
> +{

please make this function as file static, so there is no need to expose it as API of the KRun class

> krun.cpp:310
> +// Helper function that attempts to set execute bit for given file.
> +static bool setExecuteBit(const QString &fileName)
> +{

maybe this function could return the error string on failure as out parameter, so ...

> krun.cpp:372
> +                                window,
> +                                i18n("<qt>Unable to make file <b>%1</b> executable!</qt>", u.toLocalFile())
> +                            );

... here this dialog can show the error to the user

(also, please drop the exclamation mark from the message)

> krun.cpp:1439
>      }
> +
>      if (!KRun::runUrl(d->m_strURL, type, d->m_window, runFlags, d->m_suggestedFileName, d->m_asn)) {

extra empty line

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D22510

REVISION DETAIL
  https://phabricator.kde.org/D22510

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190902/93171379/attachment.html>