D22510: Added dialog to set execute permission for executable file when trying to run it.

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks for the changes. Looks ok to me now, despite some more nitpicks ;)
  Do you have a developer account to submit this?

INLINE COMMENTS

> krun.cpp:147
>      QMimeDatabase db;
>      QMimeType mimeType = db.mimeTypeForName(mimetype);
>      if (!mimeType.inherits(QStringLiteral("application/x-executable"))

I wonder why this doesn't use isExecutable(mimetype)...

> krun.cpp:167
> +    QFileInfo file(fileName);
> +    if (!file.isExecutable()) {
> +        return false;

This could now be simplified to `return file.isExecutable();`

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D22510

REVISION DETAIL
  https://phabricator.kde.org/D22510

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190902/48e44135/attachment-0001.html>