D23625: Use QString::count(QChar) over QString::split().length() - 1

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Sep 2 12:23:18 BST 2019


apol added inline comments.

INLINE COMMENTS

> normalvimode.cpp:3844
>      KTextEditor::Cursor cAfter = pasteLocation;
> -    const QStringList textLines = pastedText.split(QStringLiteral("\n"));
> +    const QStringList textLines = pastedText.split(QLatin1Char('\n'));
>      if (textLines.length() == 1) {

you didn't port this one to count?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23625

To: kossebau, #kate, cullmann
Cc: apol, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190902/a295dd4f/attachment.html>


More information about the Kde-frameworks-devel mailing list