D23660: [KRun] Check mime type for isExecutableFile first

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: dfaure, meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The mime type is passed into the function, so it's already known. Checking mime type inheritance then is quick.
  This avoids accessing the file in `QFileInfo::isExecutable()` potentially blocking just to then realize it's none of the mime types we care about.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23660

AFFECTED FILES
  src/widgets/krun.cpp

To: broulik, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190902/fb06eaed/attachment.html>