D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

Jan Grulich noreply at phabricator.kde.org
Mon Sep 2 09:25:34 BST 2019


jgrulich added inline comments.

INLINE COMMENTS

> utils.h:86
> +
> +    QDateTime clockBootTimeToQDateTime(const qlonglong &clockBootime);
>  }

1. Missing NETWORKMANAGERQT_EXPORT
2. I would remove 'Q' from the name → clockBootTimeToDateTime
3. just qlonglong clockBoottime, no const and &

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D23576

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190902/8541748a/attachment.html>


More information about the Kde-frameworks-devel mailing list