D23645: Do not generate string list at runtime

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> katemodemanager.cpp:214
>      if (! fileName.isEmpty()) {
> -        static const QStringList commonSuffixes = QStringLiteral(".orig;.new;~;.bak;.BAK").split(QLatin1Char(';'));
> +        static const QLatin1String commonSuffixes[] = {
> +            QLatin1String(".orig"),

I would even prefer:

  static const auto commonSuffixes = { ... };

This way it's an initializer_list and a pattern we use at other places in KTextEditor as well. But of course, your patch is correct as well! Runtime should be the same.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23645

To: kossebau, #kate, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190901/6835a88e/attachment-0001.html>